Merged
Conversation
Closed
ghost
requested review from
DSpeichert,
EvilHero90,
MillhioreBT,
Znote,
djarek,
kornholi and
nekiro
Member
Author
|
Somehow I removed the http server when rebasing |
ranisalt
force-pushed
the
http-login
branch
3 times, most recently
from
5f11e7c to
eb89c14
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| #include "tools.h" | ||
|
|
||
| bool Vocations::loadFromXml() | ||
| bool Vocations::loadFromXml(std::istream& is, std::string_view filename) |
Check warning
Code scanning / CodeQL
Poorly documented large function
EvilHero90
requested changes
May 31, 2024
EvilHero90
reviewed
May 31, 2024
EvilHero90
reviewed
May 31, 2024
EvilHero90
reviewed
May 31, 2024
EvilHero90
reviewed
May 31, 2024
EvilHero90
reviewed
May 31, 2024
EvilHero90
previously approved these changes
May 31, 2024
Contributor
EvilHero90
left a comment
EvilHero90
left a comment
There was a problem hiding this comment.
sorry for the 1000 commits but tests are fully working now.
EvilHero90
added
enhancement
6 tasks
csantbr
pushed a commit
to csantbr/forgottenserver-downgrades
that referenced
this pull request
Dec 22, 2024
Adds a login http server which is build on boost-beast Co-authored-by: Mario <Shadow280690@hotmail.de>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
We need to provide a HTTP login server in order to allow connections from recent client versions. HTTP login can (and most likely should) be provided by an AAC that already provides other HTTP services such as a website and an API, but for simple servers we can embed a minimal login server so that a server can be fully started without external tools.
Related work:
Opposite to the two linked pull requests, this only provides a minimal login server and players online endpoint. There are no Lua handlers or support for any other routes, which should be responded by the AAC - news, event calendar, and possibly others.
In the future, when boosted creature/boss are implemented, we can also modify the HTTP server to respond to these routes.
This pull request must be merged after #4675 otherwise it is too massive!Merging it as is will also close #4661