Move connection manager singleton to namespace#4691
Closed
ramon-bernardo wants to merge 1 commit intootland:masterfrom
ramon-bernardo:connection-namespace
Closed
Move connection manager singleton to namespace#4691ramon-bernardo wants to merge 1 commit intootland:masterfrom ramon-bernardo:connection-namespace
ramon-bernardo wants to merge 1 commit intootland:masterfrom
ramon-bernardo:connection-namespace
Conversation
ramon-bernardo
commented
May 19, 2024
Comment on lines
+54
to
+59
| void Connection::shutdownAndClose() | ||
| { | ||
| boost::system::error_code error; | ||
| socket.shutdown(boost::asio::ip::tcp::socket::shutdown_both, error); | ||
| socket.close(error); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
If not, the socket should be public here to be accessed in the tfs::io::connection namespace.
ghost
requested review from
EvilHero90
added
the
enhancement
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
tfs::ionamespace.