Move config manager singleton to namespace#4653
Merged
ranisalt merged 1 commit intootland:masterfrom Apr 27, 2024
Merged
Conversation
9d315a4 to
f7d7590
Compare
ghost
approved these changes
Apr 21, 2024
f7d7590 to
d6ff4b7
Compare
d6ff4b7 to
87b46ef
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Using a namespace rather than a singleton/global has two major advantages:
getInstancestatic method, but this is verbose)It also reduces the size of the header by hiding what would be
privatein an anonymous namespace, and gives better opportunity to optimize it (no external interface to respect = compiler can go nuts)Issues addressed: