✨ show non-compliant code changes for CI-Tests, Code-Review and SAST checks in --show-details mode#2835
Merged
spencerschrock merged 9 commits intoossf:mainfrom Apr 21, 2023
Merged
Conversation
ashishkurmi
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan,
raghavkaul and
spencerschrock
as code owners
laurentsimon
reviewed
Apr 7, 2023
… checks in --show-details mode Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
ashishkurmi
force-pushed
the
ak-fix-2798
branch
from
7670935 to
3ea87d4
Compare
naveensrinivasan
removed request for
azeemshaikh38,
justaugustus,
naveensrinivasan,
raghavkaul and
spencerschrock
ashishkurmi
had a problem deploying
to
integration-test
GitHub Actions
Failure
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
laurentsimon
approved these changes
Apr 13, 2023
Contributor
laurentsimon
left a comment
laurentsimon
left a comment
There was a problem hiding this comment.
Thank you, LGTM. I will let @spencerschrock do a final pass and merge the PR in
spencerschrock
approved these changes
Apr 18, 2023
Member
spencerschrock
left a comment
spencerschrock
left a comment
There was a problem hiding this comment.
Overall looks good. Thanks for helping improve the results!
I've left 1-2 comments
Contributor
|
Wrt. Code Review logging changes, no need to revert them - I'll rebase on top of this. |
Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io>
Contributor
Author
@spencerschrock thanks Spencer for reviewing the PR and providing your feedback, I have addressed all of your comments in my latest PR. |
spencerschrock
had a problem deploying
to
integration-test
GitHub Actions
Failure
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2835 +/- ##
==========================================
+ Coverage 51.64% 51.73% +0.08%
==========================================
Files 158 158
Lines 12075 12109 +34
==========================================
+ Hits 6236 6264 +28
- Misses 5475 5480 +5
- Partials 364 365 +1 |
Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
balteravishay
pushed a commit
to balteravishay/scorecard
that referenced
this pull request
May 29, 2023
…checks in --show-details mode (ossf#2835) * showing non-compliant code changes for CI-Tests, Code-Review and SAST checks in --show-details mode Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * changing code review non-compliant revision traces to Debug from Warn Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * changing ci test non-compliant revision trace to Debug from Warn Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * unit test fixes in code_review_test.go Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> * Incorporating Spencer's feedback Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> --------- Signed-off-by: Ashish Kurmi <akurmi@stepsecurity.io> Signed-off-by: Avishay <avishay.balter@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix for #2798
This change shows non-compliant code changes for CI-Tests, Code-Review and SAST checks when scorecard is run in
--show-detailsmode.What is the current behavior?
These checks do not show non-compliant code changes in
Detailsfield when scorecard is run in--show-detailsmode.What is the new behavior (if this is a feature change)?**
These shows show non-compliant Pull Requests and/or Commit SHAs in
Detailsfield when scorecard is run in--show-detailsmode.Which issue(s) this PR fixes
Fixes #2798
Special notes for your reviewer
Does this PR introduce a user-facing change?
Yes
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)
Signed-off-by: Ashish Kurmi akurmi@stepsecurity.io