🌱 Refactor githubrepo CheckRun logic#2710
Merged
azeemshaikh38 merged 2 commits intoossf:mainfrom Mar 2, 2023
Merged
Conversation
azeemshaikh38
requested review from
justaugustus,
laurentsimon,
naveensrinivasan,
raghavkaul and
spencerschrock
as code owners
azeemshaikh38
temporarily deployed
to
integration-test
GitHub Actions
Inactive
azeemshaikh38
force-pushed
the
check_suite
branch
from
805ba1c to
1fe9644
Compare
azeemshaikh38
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2710 +/- ##
==========================================
+ Coverage 41.29% 41.31% +0.02%
==========================================
Files 123 123
Lines 10046 10039 -7
==========================================
Hits 4148 4148
+ Misses 5602 5595 -7
Partials 296 296 |
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
azeemshaikh38
force-pushed
the
check_suite
branch
from
1fe9644 to
5c99f59
Compare
azeemshaikh38
temporarily deployed
to
integration-test
GitHub Actions
Inactive
laurentsimon
approved these changes
Mar 2, 2023
Contributor
laurentsimon
left a comment
laurentsimon
left a comment
There was a problem hiding this comment.
@spencerschrock ptal
azeemshaikh38
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
Shofiya2003
pushed a commit
to Shofiya2003/scorecard
that referenced
this pull request
Mar 10, 2023
Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Signed-off-by: Shofiya2003 <shofiyabootwala@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring to keep all check run code in one place. No logic change.
What is the current behavior?
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)