🐛 Remove unnecessary Printf #2557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Prinft causes the output to be invalid, printing for example: "got codeowners file at .github/CODEOWNERS" Signed-off-by: Luca Comellini <[email protected]>
lucacome
requested review from
azeemshaikh38,
justaugustus,
laurentsimon,
naveensrinivasan and
spencerschrock
as code owners
lucacome
temporarily deployed
to
integration-test
GitHub Actions
Inactive
|
Integration tests success for |
Contributor
|
@lucacome Thank you! |
laurentsimon
approved these changes
Dec 21, 2022
This was referenced Dec 21, 2022
raghavkaul
pushed a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
The Prinft causes the output to be invalid, printing for example: "got codeowners file at .github/CODEOWNERS" Signed-off-by: Luca Comellini <[email protected]> Signed-off-by: Luca Comellini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
scorecardprints messages likegot codeowners file at .github/CODEOWNERSwhich makes the result invalid, at least when using https://github.com/ossf/scorecard-action with sarif outputexample: https://github.com/nginxinc/nginx-kubernetes-gateway/actions/runs/3744585459/jobs/6358515861#step:4:238
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
NONE
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)