Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2529 +/- ##
==========================================
- Coverage 40.73% 40.69% -0.05%
==========================================
Files 115 115
Lines 9613 9609 -4
==========================================
- Hits 3916 3910 -6
- Misses 5418 5419 +1
- Partials 279 280 +1 |
|
Integration tests success for |
Signed-off-by: Raghav Kaul <raghavkaul@google.com>
instead of all Signed-off-by: Raghav Kaul <raghavkaul@google.com>
894f4e1 to
f0228ef
Compare
|
Integration tests success for |
|
Integration tests success for |
raghavkaul
added a commit
to raghavkaul/scorecard
that referenced
this pull request
Feb 9, 2023
* Add E2E tests Signed-off-by: Raghav Kaul <raghavkaul@google.com> * Change RequiredApprovers so that it checks for any reviewers on the list instead of all Signed-off-by: Raghav Kaul <raghavkaul@google.com> Signed-off-by: Raghav Kaul <raghavkaul@google.com> Co-authored-by: Azeem Shaikh <azeemshaikh38@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add E2E tests. Also refactor the check runner to allow dependency injection.