🐛 Replace deprecated set-output with GITHUB_OUTPUT

[gabibguti]

What kind of change does this PR introduce?

Replace deprecated set-output with GITHUB_OUTPUT on workflows.

• PR title follows the guidelines defined in our pull request documentation

What is the current behavior?

Use set-output to set outputs in workflows.

What is the new behavior (if this is a feature change)?**

Use GITHUB_OUTPUT to set outputs in workflows.

• Tests for the changes have been added (for bug fixes/features)

Which issue(s) this PR fixes

Fixes #2376

Special notes for your reviewer

I was not able to run E2E tests with make e2e-pat.

Does this PR introduce a user-facing change?

For user-facing changes, please add a concise, human-readable release note to
the release-note

(In particular, describe what changes users might need to make in their
application as a result of this pull request.)

NONE

[naveensrinivasan]

Thanks! We need to test this before merging. Could you please post a link to the workflow on your fork?

[github-actions]

Integration tests success for
[2cf10e4]
(https://github.com/ossf/scorecard/actions/runs/3299999595)

[codecov]

Codecov Report

Merging #2384 (fb51f44) into main (fa6cceb) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2384   +/-   ##
=======================================
  Coverage   40.61%   40.61%           
=======================================
  Files         112      112           
  Lines        8831     8831           
=======================================
  Hits         3587     3587           
  Misses       4984     4984           
  Partials      260      260           

[gabibguti]

Thanks! We need to test this before merging. Could you please post a link to the workflow on your fork?

No problem! Not sure which link do you mean tho.

Workflow file links
https://github.com/gabibguti/scorecard/blob/main/.github/workflows/slsa-goreleaser.yml
https://github.com/gabibguti/scorecard/blob/main/.github/workflows/goreleaser.yaml

Action links
https://github.com/gabibguti/scorecard/actions/workflows/goreleaser.yaml
https://github.com/gabibguti/scorecard/actions/workflows/slsa-goreleaser.yml

[spencerschrock]

Action links

They both say This workflow has no runs yet.

https://github.com/gabibguti/scorecard/actions/workflows/goreleaser.yaml

You can trigger the goreleaser workflow by pushing a tag to your fork

https://github.com/gabibguti/scorecard/actions/workflows/slsa-goreleaser.yml

You can trigger the slsa-goreleaser manually by following this

[gabibguti]

Should I modify anything in these workflows to test? Like changing upload-assets: true to false in goreleaser?
https://github.com/gabibguti/scorecard/blob/main/.github/workflows/goreleaser.yaml#L85

[spencerschrock]

Should I modify anything in these workflows to test? Like changing upload-assets: true to false in goreleaser? https://github.com/gabibguti/scorecard/blob/main/.github/workflows/goreleaser.yaml#L85

As far as I know, that just determines if a release gets updated to your fork which is fine https://github.com/gabibguti/scorecard/releases

I see the SLSA releaser failed, but the output value seems to have worked https://github.com/gabibguti/scorecard/actions/runs/3300430916/jobs/5444920630#step:1:29

[naveensrinivasan]

Thank you @gabibguti!

[github-actions]

Integration tests success for
[fb51f44]
(https://github.com/ossf/scorecard/actions/runs/3303750695)

[gabibguti]

Just for reference, I tested the goreleaser workflow and everything seems fine. Goreleaser failed 'cause I did not set a GPG key secret in my fork, but the version_ldflags output was set fine in the previous step. I tested echo-ing the version_ldflags output in a separate workflow.