🐛 Add custom packaging workflow for Python#1654
Merged
naveensrinivasan merged 2 commits intoossf:mainfrom Feb 17, 2022
Merged
Conversation
Packaging workflows are allowed to have `contents: write` permission. By adding relekang/python-semantic-release to the list of packaging GitHub Actions workflows, we avoid false positivies in the token permission check.
behnazh-w
requested review from
azeemshaikh38,
inferno-chromium,
justaugustus,
laurentsimon and
naveensrinivasan
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1654 +/- ##
==========================================
+ Coverage 56.10% 59.02% +2.91%
==========================================
Files 72 72
Lines 6495 6506 +11
==========================================
+ Hits 3644 3840 +196
+ Misses 2606 2415 -191
- Partials 245 251 +6 |
|
Integration tests success for |
|
Integration tests success for |
1 task
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #1642 by adding
relekang/python-semantic-releaseto the list of accepted packaging Actions workflows for Python, and provides the corresponding unit test.Packaging workflows are allowed to have
contents: writepermission. This change prevents false positives in token permission checks forrelekang/python-semantic-releaseworkflow in GitHub Actions.