106: secure registry auth #231
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzihlmann
force-pushed
the
106-secure-registry-auth
branch
3 times, most recently
from
412567d to
dcb1016
Compare
Copied from authn.DefaultKeychain but instead of parsing on every request We store the credentials in memory. This will allow us to delete the files after initial loading
mzihlmann
force-pushed
the
106-secure-registry-auth
branch
from
dcb1016 to
2b927a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied from authn.DefaultKeychain but instead of parsing on every request We store the credentials in memory. This will allow us to delete the files after initial loading
Fixes # in case of a bug fix, this should point to a bug and any other related issue(s)
Description
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.