-
Notifications
You must be signed in to change notification settings - Fork 42
Add full tags to 0.3 issues API JSON response #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Tests are fine on my local instance. I recommend merging it after #540 |
| params=Depends(commons_params.params), | ||
| i18n: i18n.Translator = Depends(i18n.i18n), | ||
| ) -> Dict[Literal["issues"], List[Dict[str, Any]]]: | ||
| params.limit = min(params.limit, 100000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You lost the custom max limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that issues() relies on _issues() instead of query._gets(), I kept it at https://github.com/osmose-qa/osmose-frontend/pull/536/files#diff-207e11f1ac32911ffb416b8ab839fc02cb1dde93e94b5f4dea2515ffd51262b1R159
|
You add |
|
It was already set to true for any output that relies on I set it to true in many outputs because in my PR |
Following discussion, this PR propose to extend the issues API response with not only elems ids but tags as well, just like in the geojson.
Currently stuck in the test because of i18n so it's currently draft