Skip to content

feat: update package dependencies and improve function signatures #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

feat: update package dependencies and improve function signatures #112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ let package = Package(
],
dependencies: [
// .package(path: "/Users/joannisorlandos/git/joannis/swift-nio-ssh"),
.package(name: "swift-nio-ssh", url: "https://github.com/Joannis/swift-nio-ssh.git", "0.3.2" ..< "0.4.0"),
.package(name: "swift-nio-ssh", url: "https://github.com/Joannis/swift-nio-ssh.git", "0.3.4" ..< "0.4.0"),
Copy link

Copilot AI Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The dependency version specifier for swift-nio-ssh uses a closed range while other dependencies use from: syntax. For consistency, consider using the from: API across all package dependencies.

Suggested change
.package(name: "swift-nio-ssh", url: "https://github.com/Joannis/swift-nio-ssh.git", "0.3.4" ..< "0.4.0"),
.package(name: "swift-nio-ssh", url: "https://github.com/Joannis/swift-nio-ssh.git", from: "0.3.4"),

Copilot uses AI. Check for mistakes.
.package(url: "https://github.com/apple/swift-log.git", from: "1.0.0"),
.package(url: "https://github.com/attaswift/BigInt.git", from: "5.2.0"),
.package(url: "https://github.com/apple/swift-crypto.git", "1.0.0" ..< "2.1.0"),
.package(url: "https://github.com/apple/swift-crypto.git", from: "3.12.3"),
Copy link

Copilot AI Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The swift-crypto dependency has been updated to a new major version without an upper bound. To prevent unintentional breaking changes, consider adding an upper bound or aligning with the version range pattern used elsewhere.

Suggested change
.package(url: "https://github.com/apple/swift-crypto.git", from: "3.12.3"),
.package(url: "https://github.com/apple/swift-crypto.git", "3.12.3" ..< "4.0.0"),

Copilot uses AI. Check for mistakes.
.package(url: "https://github.com/mtynior/ColorizeSwift.git", from: "1.5.0"),
],
targets: [
Expand Down
2 changes: 1 addition & 1 deletion Sources/Citadel/Algorithms/DH-Helpers.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ extension ByteBuffer {

let serialized = Array(bignum.serialize())
(buffer.baseAddress! + 1)
.assign(from: serialized, count: serialized.count)
.update(from: serialized, count: serialized.count)

if buffer[1] & 0x80 != 0 {
size += 1
Expand Down
2 changes: 1 addition & 1 deletion Sources/Citadel/Algorithms/RSA.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ extension Insecure.RSA {
let result = CCryptoBoringSSL_RSA_sign(
NID_sha1,
hash,
UInt32(hash.count),
Int(hash.count),
out,
&outLength,
context
Expand Down
2 changes: 1 addition & 1 deletion Sources/Citadel/OpenSSHKey.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ extension Curve25519.Signing.PrivateKey: ByteBufferConvertible {

extension ByteBuffer {
mutating func decryptAES(
cipher: UnsafePointer<EVP_CIPHER>,
cipher: OpaquePointer,
key: [UInt8],
iv: [UInt8]
) throws {
Expand Down