Repository navigation
Build the reduced-motion mocks from the real media query list - #442
Merged
Merged
Conversation
The npm update in #430 brings a typescript-eslint that flags the deprecated MediaQueryList addListener and removeListener, which the two reduced-motion tests spelled out in hand-built matchMedia mocks, so lint failed and the update could not merge. The mocks now take the browser's own MediaQueryList and only force its matches, so they name no deprecated member and keep the real listener methods. The tests check the same thing as before: a long name stays still and shows whole in a tip for a user who asked for reduced motion. Verified with lint, typecheck and the two tests on Chromium and WebKit, both with the current packages and with those of the update.
zuurbr
enabled auto-merge
November 20, 2026 16:51
AI review: no Important findingsThe change touches two app tests, ui/tests/app/long-names.test.ts and ui/tests/app/track-list.test.ts. Their prefers-reduced-motion mock used to return a hand-built fake; it now wraps the browser's real MediaQueryList and overrides only Fix or answer each Important finding. A maintainer can comment |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The npm update in #430 brings a typescript-eslint that flags the deprecated
MediaQueryListaddListenerandremoveListener. The two reduced-motion tests spelled those out in hand-builtmatchMediamocks, so lint fails and the update cannot merge.The mocks now take the browser's own
MediaQueryListand only force itsmatches, asnative-mode.test.tsandpixel-ratio.test.tsalready do. The tests still check that a long name stays still and shows whole in a tip for a user who asked for reduced motion.Verified: lint, typecheck, format and both tests on Chromium and WebKit, with the current packages and with #430's.
Once this merges, #430 can be rebased and merged.