Protanopia & Deuteranopia themes use too similar colors

[alxs]

Select Topic Area

Product Feedback

Body

The color used for additions is indistinguishable from that used for collapsed sections - at least for people with Deuteranopia. This makes it difficult for users to differentiate between the two and can lead to confusion and potential mistakes during the code review process.

Protanopia & Deuteranopia	Normal

Note that this also applies to the dark theme.

Why it's an issue:

• Confusion during code review: When reviewing changes in code, it's essential to quickly and accurately identify additions and collapsed sections. The inability to distinguish these two elements can cause confusion, leading to an inefficient code review process and potential errors.

• Decreased readability: Colors play a crucial role in enhancing the readability and user experience of any interface. When colors are too similar, it becomes challenging to differentiate between various elements, which can decrease the overall readability of the code.

• Inaccurate understanding of changes: If users are unable to identify the additions properly, they may not have a clear understanding of the changes made. This can result in an incorrect assessment of the changes' impact and may lead to incorrect decisions during the review process.

• Accessibility concerns: For users with color vision deficiencies, the inability to distinguish between similar colors can exacerbate the problem, making the interface even more challenging to use and understand.

[cehfisher]

Hello @alxs - thank you for providing this feedback! We will file this with our Accessibility team so that it can be reviewed and will follow-up here with any additional questions or updates. Thanks again!

[github-actions[bot]]

💬 Your Product Feedback Has Been Submitted 🎉

Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users.

Here's what you can expect moving forward ⏩

• Your input will be carefully reviewed and cataloged by members of our product teams. 
  • Due to the high volume of submissions, we may not always be able to provide individual responses.
  • Rest assured, your feedback will help chart our course for product improvements.
• Other users may engage with your post, sharing their own perspectives or experiences. 
• GitHub staff may reach out for further clarification or insight. 
  • We may 'Answer' your discussion if there is a current solution, workaround, or roadmap/changelog post related to the feedback.

Where to look to see what's shipping 👀

• Read the Changelog for real-time updates on the latest GitHub features, enhancements, and calls for feedback.
• Explore our Product Roadmap, which details upcoming major releases and initiatives.

What you can do in the meantime 💻

• Upvote and comment on other user feedback Discussions that resonate with you.
• Add more information at any point! Useful details include: use cases, relevant labels, desired outcomes, and any accompanying screenshots.

As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities.

Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐

[github-actions[bot]]

🕒 Discussion Activity Reminder 🕒

This Discussion has been labeled as dormant by an automated system for having no activity in the last 60 days. Please consider one the following actions:

1️⃣ Close as Out of Date: If the topic is no longer relevant, close the Discussion as out of date at the bottom of the page.

2️⃣ Provide More Information: Share additional details or context — or let the community know if you've found a solution on your own.

3️⃣ Mark a Reply as Answer: If your question has been answered by a reply, mark the most helpful reply as the solution.

Note: This dormant notification will only apply to Discussions with the Question label. To learn more, see our recent announcement.

Thank you for helping bring this Discussion to a resolution! 💬

[alxs]

@cehfisher can we mark this as a bug instead of a question?

[cehfisher]

Done!

[cehfisher]

Hi @alxs - good news! It looks like this issue has been resolved in the latest theme updates. I’m attaching screenshots of the different themes as they appear on a pull request, but we’d appreciate it if you could re-test on your end as well.

Note: some of the theme names have changed since you originally reported this issue.

Pull request - colorblind theme (dark)

Pull request - tritanopia theme (dark)

Pull request - soft theme (dark)

Pull request - default theme (dark)

Pull request - colorblind theme (light)

Pull request - tritanopia theme (light)

Pull request - default theme (light)