fix: remove deprecated overflow-y:overlay in .pm__body#827
Open
terminalchai wants to merge 1 commit into
Open
Conversation
The overlay value is non-standard and was removed in Chrome 112+. The overflow-y: auto declaration above it handles scrolling correctly. Fixes orestbida#784
✅ Deploy Preview for cookieconsentv3-playground ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.pm__bodyin the preferences modal has:overflow-y: overlayis a non-standard, deprecated value that was originally a Chrome/WebKit extension to render the scrollbar on top of content (overlay scrollbars) rather than taking up layout space. It was removed in Chrome 112 (April 2023) and has never been part of any CSS spec.In Chrome 112+ and all other engines (Firefox, Safari) the
overlayline is silently ignored, making it dead code. It also generates console warnings in some tooling.Closes #784.
Fix
Remove the dead
overflow-y: overlayline from_preferences-modal.scssand all compiled dist outputs (cookieconsent.css,cookieconsent.esm.js,cookieconsent.umd.js,preferences-modal.css).The
overflow-y: autodeclaration immediately above it already provides the correct scrolling behaviour on all browsers.