Remove ModelTraining and ModelEvaluation projects from main branch#318
Remove ModelTraining and ModelEvaluation projects from main branch#318dthaler wants to merge 1 commit intoorcasound:mainfrom
Conversation
The ModelTrainingAndEvaluation branch still contains the deprecated code. Fixes orcasound#239 Signed-off-by: Dave Thaler <[email protected]>
dthaler
requested review from
akashmjn,
bnestor,
micya,
pastorep and
scottveirs
as code owners
dthaler
added
model training
dthaler
changed the title
|
I’m not sold yet on removing this code. I would wait until we’ve fully deployed a new model from the new repo. What’s the reasoning for doing this now? |
@pastorep As the github subteam lead, I am trying to clean up the repository and you noted in zulip that the code was deprecated (which I quoted in the issue). And as noted in the issue, dependabot files PRs against them and if the code isn't used then that's not necessary and they can be closed. That said, you're the model subteam lead so you can decide when is the right time to merge this, but the code is still there even after this is merged, it's just in a different branch that code scanning, dependabot, etc. won't run on. |
3 participants
The ModelTrainingAndEvaluation branch still contains the deprecated code.
Fixes #239