Skip to content

Add dependabot support#223

Merged
dthaler merged 2 commits intoorcasound:mainfrom
dthaler:dependabot
Feb 26, 2025
Merged

Add dependabot support#223
dthaler merged 2 commits intoorcasound:mainfrom
dthaler:dependabot

Conversation

@dthaler
Copy link
Collaborator

@dthaler dthaler commented Feb 26, 2025

Several github actions used by workflows are out of date and can be automatically checked by dependabot.

Several github actions used by workflows are out of date
and can be automatically checked by dependabot.

Signed-off-by: Dave Thaler <[email protected]>
@dthaler
Copy link
Collaborator Author

dthaler commented Feb 26, 2025

See also PR #218 comments.

@micya
Copy link
Member

micya commented Feb 26, 2025

The only concern I have is that python is notorious for being very peculiar about package versions (ex: things magically break after version upgrades). Allowing bots to auto-update without verification seems dangerous to me.

Further, there is no automatic deployment to parts of the system (ex: inference system). If there is divergence between the package versions in source vs what is deployed, a breakage may not be caught until much later where it is difficult to diagnose what exactly broke.

@dthaler
Copy link
Collaborator Author

dthaler commented Feb 26, 2025

The only concern I have is that python is notorious for being very peculiar about package versions (ex: things magically break after version upgrades). Allowing bots to auto-update without verification seems dangerous to me.

Bots cannot auto-update. Bots file a pull request that then goes through review/verification just like any other PR from a human would.

Further, there is no automatic deployment to parts of the system (ex: inference system). If there is divergence between the package versions in source vs what is deployed, a breakage may not be caught until much later where it is difficult to diagnose what exactly broke.

This PR does not change that. The same thing would happen with any human generated PR if the PR is merged without testing for breakage.

@micya
Copy link
Member

micya commented Feb 26, 2025

I would not approve a PR without the author confirming that they have tested the change. A bot cannot do that. Therefore, I will not approve the bot's PRs. In that case, I don't see the value in enabling the bot.

Signed-off-by: Dave Thaler <[email protected]>
@dthaler
Copy link
Collaborator Author

dthaler commented Feb 26, 2025

I would not approve a PR without the author confirming that they have tested the change. A bot cannot do that. Therefore, I will not approve the bot's PRs. In that case, I don't see the value in enabling the bot.

I think your comment applies to the docker part (which I've now removed) but not the github-actions part. The github actions don't affect the binaries or deployment, only what github does with pull requests or periodically. A bot can test those changes since the github workflows run on pull requests. Hence there is value in enabling the bot for such things.

@dthaler dthaler merged commit cb2c1e0 into orcasound:main Feb 26, 2025
@micya
Copy link
Member

micya commented Mar 1, 2025 via email

@dthaler
Copy link
Collaborator Author

dthaler commented Mar 1, 2025

I noticed the dependabot updates modified certain GitHub Actions but did not trigger them (likely because there is a path filter on those actions). Can you take a look?

You're right. I just triggered them manually and they all passed (as can be seen here). I can file a PR to add the relevant yml file to the paths so they trigger automatically.

@dthaler
Copy link
Collaborator Author

dthaler commented Mar 1, 2025

PR #226 filed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants