Convert to v2 addon, require Ember 4.12+ #421
Merged
+3,703
−4,162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobbieTheWagner
force-pushed
the
addon-v2
branch
from
6e37343 to
cd0ae45
Compare
RobbieTheWagner
force-pushed
the
addon-v2
branch
from
d36760d to
f2a2633
Compare
Comment on lines
+102
to
+85
| orbitRegistry.schemaVersion = config?.schemaVersion; | ||
| injectModules(modules); |
Contributor
There was a problem hiding this comment.
I'd call this "build internal registry" or something similar -- injection is like, using the @service decorator to pull something in, but 🤷
|
|
||
| export function applyStandardSourceInjections( | ||
| injections: RecordSourceSettings, | ||
| ): void { |
Contributor
There was a problem hiding this comment.
maybe for a followup, I think using the service decorator directly in each thing that uses this would be clearer.
This pattern sort of is re-creating the implicit injections we used to have an application initializers.
Contributor
Author
There was a problem hiding this comment.
This is to pass things to the underlying orbit things. It's not services.
| { | ||
| ...dataModels, | ||
| ...dataSources, | ||
| ...dataStrategies, |
Contributor
There was a problem hiding this comment.
this is maybe stylistic, but I'd inline the import.meta.globs here
RobbieTheWagner
changed the title
dgeb
approved these changes
Oct 2, 2025
CONTRIBUTING.md
Outdated
|
|
||
| - `git clone <repository-url>` | ||
| - `cd ember-orbit` | ||
| - `cd ` |
Contributor
Author
There was a problem hiding this comment.
Ah, no it is not! Will fix. Thanks!
Co-authored-by: NullVoxPopuli <[email protected]>
Co-authored-by: NullVoxPopuli <[email protected]>
RobbieTheWagner
force-pushed
the
addon-v2
branch
from
6511e37 to
358cfb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds upon the work in #420 and converts ember-orbit to be a v2 addon.
There are several breaking changes involved here:
setupOrbitmanually in consuming appsorbitRegistrynow exists for registering models etc