docs: document PackManifestOptions to make PackManifest reproducible#749
Conversation
wangxiaoxuan273
requested review from
SteveLasker,
Wwwsylvia,
sajayantony and
shizhMSFT
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #749 +/- ##
=======================================
Coverage 77.92% 77.92%
=======================================
Files 63 63
Lines 4694 4694
=======================================
Hits 3658 3658
Misses 656 656
Partials 380 380 ☔ View full report in Codecov by Sentry. |
Wwwsylvia
left a comment
Wwwsylvia
left a comment
There was a problem hiding this comment.
We also need to rephrase the related comment a bit for ExamplePackManifest_imageV10 and ExamplePackManifest_imageV11 in example_pack_test.go.
|
BTW, the PR title should start with |
shizhMSFT
left a comment
shizhMSFT
left a comment
There was a problem hiding this comment.
You also need to update the examples in example_pack_test.go.
wangxiaoxuan273
changed the title
updated the comments in |
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
3 participants
Resolves #748