Skip to content

fix: cancel goroutine before the next one is created#739

Merged
Wwwsylvia merged 5 commits into
oras-project:mainfrom
wangxiaoxuan273:sync
Apr 8, 2024
Merged

fix: cancel goroutine before the next one is created#739
Wwwsylvia merged 5 commits into
oras-project:mainfrom
wangxiaoxuan273:sync

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Contributor

To fix #738

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Comment thread copy_test.go Outdated
Comment thread copy_test.go

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Comment thread internal/syncutil/limit.go Outdated
Comment thread internal/syncutil/limit.go
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@JeyJeyGao JeyJeyGao left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But I am not a maintainer.

Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 79c866e into oras-project:main Apr 8, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the sync branch February 5, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants