Merged
Conversation
rollback is in summary scenario logging, however this code also gets triggered by "bpftune -q summary", which erroneously rolls back tunable values. Ensure it is only run on tuner fini instead. Signed-off-by: Alan Maguire <[email protected]>
have "bpftune -q summary" output paste-able commands to replicate changes made; for example: sudo sysctl -w net.ipv4.tcp_rmem="4096 131072 781250 " Add a "bpftune -q rollback" command also; its role is to provide a pasteable set of commands to restore initial pre-bpftune state when bpftune is stopped. For example: $ bpftune -q rollback sudo sysctl -w net.ipv4.tcp_rmem="4096 131072 131072 " The latter provides a way for folks not running bpftune in rollback mode to restore original state. Signed-off-by: Alan Maguire <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these changes fix issues in rollback and provide a "rollback" query which gives a paste-able set of commands to restore to pre-bpftune sysctl settings