[WIP] Attempt to make optimas generators compatible with generator standard
#228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
force-pushed
the
standardization
branch
from
d1b7721 to
522dd9c
Compare
RemiLehe
force-pushed
the
standardization
branch
2 times, most recently
from
9f08392 to
2445546
Compare
RemiLehe
force-pushed
the
standardization
branch
from
bea343a to
0487226
Compare
3 tasks
Member
|
Looking at this, I think this approach is good. Our current interfacer in Optimas branch #209 used _ask and _tell as we did not want to do the work with Optimas data structures. Now you have moved that outside to ask_trials / tell_trials so this essentially is the same sort of wrapping but instead of ask - > _ask it is ask_trials -> ask. And the ask can use our gens. Just need to work out the line to initialize the generator, as you don't have the libE data structures. We can first try uniform sample, then gpCAM, and then APOSMM via this new interface. |
RemiLehe
commented
Sep 20, 2024
optimas/generators/base.py
Outdated
| **trial.parameters_as_dict(), | ||
| **trial.analyzed_parameters_as_dict(), | ||
| **trial.objectives_as_dict(), | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
We need to also pass the id here.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemiLehe
commented
Sep 25, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Collaborator
Author
|
Superseeded by #249 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall approach:
optimasgenerators currently call theaskandtellmethods, which, under the hood, can the_askand_tellmethods.In this PR:
ask/tellare renamed toask_trials/tell_trialsand keep the same interface (for compatibility with the rest of the framework)_ask/_tellare renamed toask/telland adopt the new standardized interface.This allows other packages to use the
optimasgenerators. (In this case, these other packages will call the new, standardizedask/telldirectly, without going throughask_trials/tell_trials.)In order to wrap a standardized generator from another package, one would only need to make a thin wrapper around it that defines
ask_trialsandtell_trials.