Heartbeat can recover from an error condition.#201
Merged
jeremyowensboggs merged 3 commits intomasterfrom Feb 27, 2024
Merged
Conversation
criticalbh
approved these changes
Feb 26, 2024
killahwave
approved these changes
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the faktory server restarted, and we received an error from an attempted heartbeat, the heartbeat server would stop sending a heartbeat. This behavior looks like an oversight, the real goal was to continue the heartbeat until the worker was shutdown, or received a terminate request.
To fix, I included the error state in the list of states in which a heartbeat should be sent.