Skip to content

prevent crashing in testing environment when running code with Faktory batches#177

Merged
notactuallytreyanastasio merged 2 commits intoopt-elixir:masterfrom
JustinG721:support-batches-in-testing
Dec 2, 2022
Merged

prevent crashing in testing environment when running code with Faktory batches#177
notactuallytreyanastasio merged 2 commits intoopt-elixir:masterfrom
JustinG721:support-batches-in-testing

Conversation

@JustinG721
Copy link
Contributor

Return default arguments for batches when in the sandbox environment to prevent timeouts when running tests that contain them.

@JustinG721 JustinG721 changed the title prevent crashing in testing environment when Faktory batches prevent crashing in testing environment when running code with Faktory batches Dec 2, 2022
Copy link
Collaborator

@notactuallytreyanastasio notactuallytreyanastasio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future I think we could work off the env var to use two different modules here to keep testing-focused code away from the actual runtime, but that doesn't need to happen now. LGTM with a suggestion but its not essential.

Co-authored-by: Bobby Grayson <53058768+notactuallytreyanastasio@users.noreply.github.com>
@notactuallytreyanastasio notactuallytreyanastasio merged commit 40fb937 into opt-elixir:master Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants