Skip to content

fixed the directinalLight bug when running on some adreno gpu devices #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2021
Merged

fixed the directinalLight bug when running on some adreno gpu devices #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/renderers/shaders/ShaderChunk/clearcoat_normal_fragment_maps.glsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default /* glsl */`

#else

clearcoatNormal = perturbNormal2Arb( - vViewPosition, clearcoatNormal, clearcoatMapN );
clearcoatNormal = perturbNormal2Arb( - vViewPosition, clearcoatNormal, clearcoatMapN, gl_FrontFacing );

#endif

Expand Down
2 changes: 1 addition & 1 deletion src/renderers/shaders/ShaderChunk/normal_fragment_maps.glsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ export default /* glsl */`

#else

normal = perturbNormal2Arb( -vViewPosition, normal, mapN );
normal = perturbNormal2Arb( -vViewPosition, normal, mapN, gl_FrontFacing );

#endif

Expand Down
5 changes: 3 additions & 2 deletions src/renderers/shaders/ShaderChunk/normalmap_pars_fragment.glsl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ export default /* glsl */`
// Per-Pixel Tangent Space Normal Mapping
// http://hacksoflife.blogspot.ch/2009/11/per-pixel-tangent-space-normal-mapping.html

vec3 perturbNormal2Arb( vec3 eye_pos, vec3 surf_norm, vec3 mapN ) {
// param isFrontFacing is Added to fix the directinalLight bug when running on some adreno gpu devices.
vec3 perturbNormal2Arb( vec3 eye_pos, vec3 surf_norm, vec3 mapN, bool isFrontFacing) {

// Workaround for Adreno 3XX dFd*( vec3 ) bug. See #9988

Expand All @@ -40,7 +41,7 @@ export default /* glsl */`

mat3 tsn = mat3( S, T, N );

mapN.xy *= ( float( gl_FrontFacing ) * 2.0 - 1.0 );
mapN.xy *= ( float( isFrontFacing ) * 2.0 - 1.0 );

return normalize( tsn * mapN );

Expand Down