Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 3, 2025

Addresses feedback from #19429 on jQuery removal: parseInt(td.style.width) fails when width is not set via inline styles, returning NaN.

Changes

  • Replace parseInt(td.style.width) with td.offsetWidth in table-edit-form.ts
    • offsetWidth returns computed width as number (matches original jQuery .css('width') behavior)
    • Works regardless of whether width is set via inline styles, CSS classes, or computed layout
// Before (broken)
let width = parseInt(td.style.width);  // NaN if no inline style

// After (fixed)
let width = td.offsetWidth;  // Actual rendered width

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Update PR to address feedback on jQuery removal Fix width calculation in table-edit-form to use offsetWidth Nov 3, 2025
Copilot AI requested a review from myabc November 3, 2025 20:48
Copilot finished work on behalf of myabc November 3, 2025 20:48
@github-actions
Copy link

github-actions bot commented Nov 3, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

1 similar comment
@github-actions
Copy link

github-actions bot commented Nov 3, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@myabc myabc marked this pull request as ready for review November 3, 2025 21:38
@myabc myabc merged commit 3a5a8bc into code-maintenance/rid-jquery Nov 3, 2025
17 of 21 checks passed
@myabc myabc deleted the copilot/sub-pr-19429 branch November 3, 2025 21:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants