Implementation/68711 Cleanup "Other" document type (category) when not linked to any documents #20876
+191
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a database migration to clean up orphaned "Other" document types and includes comprehensive test coverage. The migration removes document types named "Other" (or its localized equivalent) that have no associated documents, preventing database clutter from unused seeded data.
Key Changes
- Added a database migration
CleanupOtherDocumentTypethat conditionally deletes orphaned "Other" document types - Implemented localization support to handle the "Other" type across different languages (e.g., "Andere" in German)
- Created thorough RSpec tests covering multiple scenarios including English and localized types, mixed scenarios, and edge cases
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| modules/documents/db/migrate/20251031071403_cleanup_other_document_type.rb | Migration that safely removes orphaned "Other" document types with localization support |
| modules/documents/spec/migrations/cleanup_other_document_type_spec.rb | Comprehensive test suite covering various scenarios for the cleanup migration |
modules/documents/db/migrate/20251031071403_cleanup_other_document_type.rb
Outdated
Show resolved
Hide resolved
modules/documents/db/migrate/20251031071403_cleanup_other_document_type.rb
Outdated
Show resolved
Hide resolved
akabiru
force-pushed
the
implementation/68711-cleanup-other-document-type-category-when-not-linked-to-any-documents
branch
from
9e8c8f8 to
cb087bf
Compare
akabiru
force-pushed
the
implementation/68711-cleanup-other-document-type-category-when-not-linked-to-any-documents
branch
from
cb087bf to
56ad5c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/68711
If there is a type called "Other" (or a translation in their team's language) AND there are no documents stored on the instance having that type then remove that type.