Skip to content

Conversation

@myabc
Copy link
Contributor

@myabc myabc commented Oct 30, 2025

Ticket

https://community.openproject.org/wp/68715

What are you trying to accomplish?

Renames "expiry" to "expiration" in:

  • docs
  • user interface
  • Setting (avatar_link_expiry to avatar_link_expiration_seconds)

What approach did you choose and why?

Merge checklist

  • Added/updated tests
  • Added/updated documentation in Lookbook (patterns, previews, etc)
  • Tested major browsers (Chrome, Firefox, Edge, ...)

@myabc myabc force-pushed the bug/68679-session-ttl-not-toggleable branch 3 times, most recently from 5b88778 to 6955290 Compare October 31, 2025 15:03
Base automatically changed from bug/68679-session-ttl-not-toggleable to dev November 3, 2025 12:23
@myabc myabc force-pushed the bug/68679-replace-expiry-with-expiration branch from 48f0cfb to 3a1d4bb Compare November 7, 2025 11:38
@myabc myabc force-pushed the bug/68679-replace-expiry-with-expiration branch from 3a1d4bb to 33a510b Compare November 7, 2025 11:42
@myabc myabc changed the title Fix wording (docs, UI): change "expiry" to "expiration" [#68715] Fix incorrect (British) usage: "expiry" vs "expiration" Nov 7, 2025
@myabc myabc force-pushed the bug/68679-replace-expiry-with-expiration branch from d390168 to f897fef Compare November 7, 2025 11:54
@myabc myabc added needs review ruby Pull requests that update Ruby code documentation labels Nov 7, 2025
@myabc myabc requested a review from MayaBerd November 7, 2025 11:55
OPENPROJECT_AUTOLOGIN__COOKIE__PATH (default="/") Cookie path for autologin cookie
OPENPROJECT_AVAILABLE__LANGUAGES (default=["ca", "cs", "de", "el", "en", "es", "fr", "hu", "id", "it", "ja", "ko", "lt", "nl", "no", "pl", "pt-BR", "pt-PT", "ro", "ru", "sk", "sl", "sv", "tr", "uk", "vi", "zh-CN", "zh-TW"]) Available languages
OPENPROJECT_AVATAR__LINK__EXPIRY__SECONDS (default=86400) Cache duration for avatar image API responses
OPENPROJECT_AVATAR__LINK__EXPIRATION__SECONDS (default=86400) Cache duration for avatar image API responses
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oliverguenther Not sure of the best way to handle renaming environment variables in deployments?

@myabc myabc marked this pull request as ready for review November 7, 2025 15:14
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

Caution

The provided work package version does not match the core version

Details:

Please make sure that:

  • The work package version OR your pull request target branch is correct

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation needs review ruby Pull requests that update Ruby code

Development

Successfully merging this pull request may close these issues.

2 participants