[#68700] Rename to weighted item list #20867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames `scored_list` to `weighted_item_list`
shiroginne
changed the base branch from
release/16.6
to
implementation/67623-remove-feature-flag
…tation/68700-rename-to-weighted-item-list
Base automatically changed from
implementation/67623-remove-feature-flag
to
release/16.6
October 30, 2025 15:51
- add migration for db column name - update AR relations in code - update display texts and locale keys - update test, method, class, variable names - fix formatting mistake in item base controller
Kharonus
force-pushed
the
implementation/68700-rename-to-weighted-item-list
branch
from
698a562 to
38d5222
Compare
Generated by 🚫 Danger |
- fix migration to rename existing data in custom fields table - update project custom fields header to show all custom fields with enterprise addon - show upsale page for hierarchies and weighted item lists
Kharonus
force-pushed
the
implementation/68700-rename-to-weighted-item-list
branch
2 times, most recently
from
f5d1ac3 to
16db2c1
Compare
- replaced images - added enterprise addon for test setups
Kharonus
force-pushed
the
implementation/68700-rename-to-weighted-item-list
branch
from
16db2c1 to
d9a8aef
Compare
Kharonus
force-pushed
the
implementation/68700-rename-to-weighted-item-list
branch
from
f74bcd8 to
8041b7c
Compare
Kharonus
force-pushed
the
implementation/68700-rename-to-weighted-item-list
branch
from
8041b7c to
4ec3810
Compare
Contributor
NobodysNightmare
left a comment
NobodysNightmare
left a comment
There was a problem hiding this comment.
See my initial batch of comments from code review. I'll quickly click through the changes before giving out an approval.
Contributor
|
🟢 Finding regarding the enterprise check: When I edit an existing weighted item list or hierarchy (but don't have the enterprise token anymore), I can see the other tabs and navigate there and make all changes I want. Only the main tab is inaccessible to me: 
|
Co-authored-by: Jan Sandbrink <[email protected]>
NobodysNightmare
approved these changes
Nov 4, 2025
Member
|
I wanted to talk to dominc about that today. The same is true for calculated values and I adopted the behaviour from there to save time. I think we need some fixing there, but not yet sure how. And maybe that is fine for 16.6.1? |
Kharonus
deleted the
implementation/68700-rename-to-weighted-item-list
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#68700
What are you trying to accomplish?
Hints