Conversation
|
Just FYI, on the Dec 25th 3.3 will be released. Maybe we can already jump on the RC1 and then move to the released version net year? It brings some more performance increases. See https://www.ruby-lang.org/en/news/2023/12/11/ruby-3-3-0-rc1-released/ |
dombesz
force-pushed
the
upgrade-ruby-and-bundler
branch
from
248ff11 to
1cc3d0b
Compare
I'd be in favor of upgrading ruby pessimistively, we've had some problems with .0 versions in the past, so I'd wait until it settled down. If the bump is easy, there's not much effort involved in upgrading twice in 13.2 |
dombesz
force-pushed
the
upgrade-ruby-and-bundler
branch
17 times, most recently
from
90116a3 to
002b541
Compare
| # rubocop:disable Layout/LineLength | ||
| # Looks like this in the job log: | ||
| # Process 28: TEST_ENV_NUMBER=28 RUBYOPT=-I/usr/local/bundle/bundler/gems/turbo_tests-3148ae6c3482/lib -r/usr/local/bundle/gems/bundler-2.4.7/lib/bundler/setup -W0 RSPEC_SILENCE_FILTER_ANNOUNCEMENTS=1 /usr/local/bundle/gems/bundler-2.4.7/exe/bundle exec rspec --seed 52674 --format TurboTests::JsonRowsFormatter --out tmp/test-pipes/subprocess-28 --format ParallelTests::RSpec::RuntimeLogger --out spec/support/turbo_runtime_features.log spec/features/api_docs/index_spec.rb spec/features/custom_fields/reorder_options_spec.rb spec/features/projects/projects_portfolio_spec.rb spec/features/projects/template_spec.rb spec/features/versions/edit_spec.rb spec/features/work_packages/details/markdown/description_editor_spec.rb spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb spec/features/work_packages/table/invalid_query_spec.rb spec/features/work_packages/tabs/activity_revisions_spec.rb | ||
| # Process 28: TEST_ENV_NUMBER=28 RUBYOPT=-I/usr/local/bundle/bundler/gems/turbo_tests-3148ae6c3482/lib -r/usr/local/bundle/gems/bundler-2.4.22/lib/bundler/setup -W0 RSPEC_SILENCE_FILTER_ANNOUNCEMENTS=1 /usr/local/bundle/gems/bundler-2.4.22/exe/bundle exec rspec --seed 52674 --format TurboTests::JsonRowsFormatter --out tmp/test-pipes/subprocess-28 --format ParallelTests::RSpec::RuntimeLogger --out spec/support/turbo_runtime_features.log spec/features/api_docs/index_spec.rb spec/features/custom_fields/reorder_options_spec.rb spec/features/projects/projects_portfolio_spec.rb spec/features/projects/template_spec.rb spec/features/versions/edit_spec.rb spec/features/work_packages/details/markdown/description_editor_spec.rb spec/features/work_packages/table/hierarchy/hierarchy_parent_below_spec.rb spec/features/work_packages/table/inline_create/inline_create_refresh_spec.rb spec/features/work_packages/table/invalid_query_spec.rb spec/features/work_packages/tabs/activity_revisions_spec.rb |
aaron-contreras
left a comment
aaron-contreras
left a comment
There was a problem hiding this comment.
Awesome!👏 I love the new Bundler syntax for specifying the ruby version in the Gemfile with your rbenv-generated .ruby-version file. The failing spec is already being addressed in another PR and is unrelated to the upgrade.
`. ___
__,' __`. _..----....____
__...--.'``;. ,. ;``--..__ .' ,-._ _.-'
_..-''-------' `' `' `' O ``-''._ (,;') _,'
,'________________ \`-._`-','
`._ ```````````------...___ '-.._'-:
```--.._ ,. ````--...__\-.
`.--. `-` ____ | |`
`. `. ,'`````. ; ;`
`._`. __________ `. \'__/`
`-:._____/______/___/____`. \ `
| `._ `. \
`._________`-. `. `.___
SSt `------'`
|
I'll merge it now, as the failing spec is unrelated to this PR. |
5 participants
https://community.openproject.org/wp/51395
As part of the rails upgrade, it is recommended to get ruby to the latest version.
The failing spec is related to the new old chrome headless version reporting itself with a different name. The issue is being addressed in a separate PR #14426 .