Skip to content

Now operator-sdk bundle validate also ensures that the annotation has a valid JSON #5495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

Now operator-sdk bundle validate also ensures that the annotation has a valid JSON #5495

merged 1 commit into from
Jan 14, 2022

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Jan 13, 2022 •
edited
Loading

Description

Now operator-sdk bundle validate also ensures that the alm-examples annotation has a valid JSON (More info), see:

Screenshot 2022-01-13 at 10 43 49

PS: Introduction done by upgrading operator-framework/api from the commit 54878ea280f7c7402549dae568916dfb330b9262 to the release v0.11.1

@openshift-ci openshift-ci bot requested review from jmrodri and joelanford January 13, 2022 10:41
rashmigottipati
rashmigottipati approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 14, 2022
jmrodri
jmrodri approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jmrodri jmrodri merged commit 566b20b into operator-framework:master Jan 14, 2022
@camilamacedo86 camilamacedo86 deleted the add-examples-check branch January 14, 2022 17:26
This was referenced Jan 16, 2022
Closed
Closed
Merged
This was referenced Feb 9, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmrodri jmrodri jmrodri approved these changes

@rashmigottipati rashmigottipati rashmigottipati approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@varshaprasad96 varshaprasad96 Awaiting requested review from varshaprasad96

@asmacdo asmacdo Awaiting requested review from asmacdo

Assignees

@jmrodri jmrodri

@rashmigottipati rashmigottipati

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@camilamacedo86 @jmrodri @rashmigottipati