Skip to content

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Dec 10, 2021

Description of the change:
add new good practices validator (operator-framework/api#197)

Motivation for the change:
This new validator will raise warnings with nice suggestions over good practices when are able to check the nit by looking at the bundles.

Screenshot 2021-12-10 at 19 31 18

Checklist

If the pull request includes user-facing changes, extra documentation is required:

Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2021
@jmrodri
Copy link
Member

jmrodri commented Dec 10, 2021

Until this PR operator-framework/enhancements#98 merges, we will continue to have to include validators into the SDK.

@camilamacedo86 camilamacedo86 merged commit 1d009d6 into operator-framework:master Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants