Support for passing old resource to validator #330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonesbusy
force-pushed
the
feature/support-old-resource
branch
from
952ac17 to
bf93df3
Compare
Contributor
Author
|
Applied spotless |
Contributor
|
@jonesbusy there some end to end test failing, this might be actually unrelated to you PR, if you could take a look however, that would be great |
Contributor
Author
|
Mhh I need to try to run those end2end tests locally as well Can you try to run again the job to be sure it's not flaky? |
csviri
reviewed
May 15, 2025
...n/java/io/javaoperatorsdk/webhook/admission/validation/DefaultAdmissionRequestValidator.java
Outdated
Show resolved
Hide resolved
Contributor
I'm pretty sure e2e broke some point, not a result of this PR. If you have time pls take a look in a separate PR, otherwise I will try to do eventually. |
csviri
approved these changes
May 21, 2025
Contributor
|
Will merge this now and take a look on e2e later. Thank you @jonesbusy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #329
This is a breaking change since the validator method changed.
The oldResource is never null. It's only different when performing an UPDATE operation
Useful to validate immutable field on the spec