warn on maxOpenShiftVersion specifying more than major.minor #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhale
reviewed
Aug 17, 2021
Signed-off-by: Ankita Thomas <[email protected]>
ankitathomas
force-pushed
the
maxopenshiftversion-warn
branch
from
8c3ab96 to
a9ff8e8
Compare
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
joelanford
reviewed
Aug 17, 2021
| } | ||
|
|
||
| truncatedMaxOcp := semver.Version{Major: semVerVersionMaxOcp.Major, Minor: semVerVersionMaxOcp.Minor} | ||
| if !semVerVersionMaxOcp.EQ(truncatedMaxOcp) { |
Member
There was a problem hiding this comment.
If olmMaxOpenShiftVersionValue is 4.8.0 it looks like this will not be tripped, right?
Is that okay, or do we want to do something like this:
regexp.MustCompile("^v?\d+\.\d+$").MatchString(olmMaxOpenShiftVersionValue)
joelanford
reviewed
Aug 17, 2021
| bundleDir: "./testdata/valid_bundle_v1beta1", | ||
| imageIndexPath: "./testdata/dockerfile/valid_bundle.Dockerfile", | ||
| annotations: map[string]string{ | ||
| "olm.properties": fmt.Sprintf(`[{"type": "olm.maxOpenShiftVersion", "value": "4.8.1"}]`), |
Member
There was a problem hiding this comment.
Add a test for 4.8.0 just to tell our future selves what the expectation is?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ankita Thomas [email protected]
validation accompanying operator-framework/operator-lifecycle-manager#2326