Skip to content

feat: Adding mustache CLI#91

Merged
sesheta merged 2 commits intooperate-first:masterfrom
tssala23:mustache
Jul 28, 2022
Merged

feat: Adding mustache CLI#91
sesheta merged 2 commits intooperate-first:masterfrom
tssala23:mustache

Conversation

@tssala23
Copy link
Member

We want to have mustache CLI available in toolbox so we can use the image in robozome automation.

@tssala23 tssala23 requested review from HumairAK and tumido as code owners July 28, 2022 11:05
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 28, 2022
@tumido tumido linked an issue Jul 28, 2022 that may be closed by this pull request
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't notice when writing the issue, that the repo is releasing binaries directly. In that case the builder image is not needed at all, so we don't need it in the PR either. Let's keep the curl/chmod here only.

Dockerfile Outdated

FROM registry.fedoraproject.org/fedora-toolbox:34

FROM registry.access.redhat.com/ubi8/go-toolset as mustache-builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed

Dockerfile Outdated
COPY --from=ksops-builder /go/src/github.com/viaduct-ai/kustomize-sops/* $KUSTOMIZE_PLUGIN_PATH/viaduct.ai/v1/ksops/
COPY --from=labels-sync-builder /ko-app/label_sync /usr/bin/labels_sync
COPY --from=peribolos-builder /ko-app/peribolos /usr/bin/peribolos
COPY --from=mustache-builder go/bin/mustache /usr/local/bin/mustache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not present in the mustache-builder.

curl -L https://github.com/pcjun97/kustomize-hash-annotator/releases/download/1.0.1/HashAnnotator_1.0.1_Linux_x86_64.tar.gz | tar -xzf - -C $KUSTOMIZE_PLUGIN_PATH/pcjun97/v1/hashannotator/
curl -L https://github.com/pcjun97/kustomize-hash-annotator/releases/download/1.0.1/HashAnnotator_1.0.1_Linux_x86_64.tar.gz | tar -xzf - -C $KUSTOMIZE_PLUGIN_PATH/pcjun97/v1/hashannotator/ && \
# Install mustache
curl -L https://github.com/cbroglie/mustache/releases/download/v${MUSTACHE_VERSION}/mustache_${MUSTACHE_VERSION}_linux_amd64.tar.gz | tar -xzf - -C /usr/local/bin && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't notice the repo releases binaries directly! That's great!

@sesheta sesheta added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 28, 2022
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@sesheta
Copy link
Member

sesheta commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tumido

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@sesheta sesheta merged commit ccede05 into operate-first:master Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add mustache cli to toolbox

3 participants