feat: Adding mustache CLI#91
Conversation
tumido
left a comment
There was a problem hiding this comment.
Oh, I didn't notice when writing the issue, that the repo is releasing binaries directly. In that case the builder image is not needed at all, so we don't need it in the PR either. Let's keep the curl/chmod here only.
Dockerfile
Outdated
|
|
||
| FROM registry.fedoraproject.org/fedora-toolbox:34 | ||
|
|
||
| FROM registry.access.redhat.com/ubi8/go-toolset as mustache-builder |
Dockerfile
Outdated
| COPY --from=ksops-builder /go/src/github.com/viaduct-ai/kustomize-sops/* $KUSTOMIZE_PLUGIN_PATH/viaduct.ai/v1/ksops/ | ||
| COPY --from=labels-sync-builder /ko-app/label_sync /usr/bin/labels_sync | ||
| COPY --from=peribolos-builder /ko-app/peribolos /usr/bin/peribolos | ||
| COPY --from=mustache-builder go/bin/mustache /usr/local/bin/mustache |
There was a problem hiding this comment.
This is not present in the mustache-builder.
| curl -L https://github.com/pcjun97/kustomize-hash-annotator/releases/download/1.0.1/HashAnnotator_1.0.1_Linux_x86_64.tar.gz | tar -xzf - -C $KUSTOMIZE_PLUGIN_PATH/pcjun97/v1/hashannotator/ | ||
| curl -L https://github.com/pcjun97/kustomize-hash-annotator/releases/download/1.0.1/HashAnnotator_1.0.1_Linux_x86_64.tar.gz | tar -xzf - -C $KUSTOMIZE_PLUGIN_PATH/pcjun97/v1/hashannotator/ && \ | ||
| # Install mustache | ||
| curl -L https://github.com/cbroglie/mustache/releases/download/v${MUSTACHE_VERSION}/mustache_${MUSTACHE_VERSION}_linux_amd64.tar.gz | tar -xzf - -C /usr/local/bin && \ |
There was a problem hiding this comment.
Oh, I didn't notice the repo releases binaries directly! That's great!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tumido The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We want to have mustache CLI available in toolbox so we can use the image in robozome automation.