Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ LABEL maintainer="Operate First" \
version.helm="${HELM_VERSION}" \
version.helm_secrets="${HELM_SECRETS_VERSION}" \
version.ksops="${KSOPS_VERSION}" \
version.sops="${SOPS_VERSION}"
version.sops="${SOPS_VERSION}" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this new slash \

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finger slip I'm sure :) fixed


# Copy ksops and kustomize from builder
COPY --from=ksops-builder /go/bin/kustomize /usr/local/bin/kustomize
Expand All @@ -45,7 +45,7 @@ RUN \
# Install yq
curl -o /usr/local/bin/yq -L https://github.com/mikefarah/yq/releases/download/${YQ_VERSION}/yq_linux_amd64 && \
chmod +x /usr/local/bin/yq

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last change -- can you remove the whitespace here, as this is failing the pre-commit check.

Copy link
Member Author

@quaid quaid Aug 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I got this, and I appreciate the connection—pre-commit legitimately failed, now I know to look further when that happens here.
/retest

COPY scripts/* /usr/local/bin/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quaid by adding it to the scripts folder, this line will auto consume your script, so you don't need to add any changes to the Dockerfile for this PR. So you can remove the curl/chmod commands you have added.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha! Yes, indeed, it's right there. I'll blame my lack of familiarity with Dockerfiles for missing the obvious., :)


CMD /bin/bash
37 changes: 37 additions & 0 deletions scripts/o1-clone
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
#!/bin/bash
# Script to clone from github.com/operate-first/ and setup the environment
# (C) 2021 Karsten Wade <[email protected]> <[email protected]
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
#
# This barebones script is not very clever, because it is just trying to
# clone a repo and set it up according to Operate First community practices:
# https://URL_FOR_COMMUNITY_PRACTICES_NEEDED
#
# Use:
# ./o1-tools/bin/o1-clone repo-name
#
# For example:
# ./o1-tools/bin/o1-clone community-handbook
#
#
# Let's presume you want something from the /operate-first/ org and take in
# the first bash variable as the repo name:
git clone [email protected]:operate-first/$1.git
# Enter the project to prepare the environment
cd $1
# Install pre-commit hooks and whatever else it does
pre-commit install
#
# That's it for now, what other environment activities could we do here?