Skip to content

modifying kustomization overlays in each cluster for opfcli onboard#1800

Closed
Gregory-Pereira wants to merge 1 commit intooperate-first:masterfrom
Gregory-Pereira:modify-overlay-kustomizations-for-opfcli-compatability
Closed

modifying kustomization overlays in each cluster for opfcli onboard#1800
Gregory-Pereira wants to merge 1 commit intooperate-first:masterfrom
Gregory-Pereira:modify-overlay-kustomizations-for-opfcli-compatability

Conversation

@Gregory-Pereira
Copy link
Member

Kustomization overlays have been restructured to be compatible with the opfcli onboard command. This will produce, small and isolated diffs when on-boarding with the opfcli rather than large ones that compete over formatting rules. Resources will now also be automatically sorted.

Related to: merging of opfcli pr 44

@sesheta sesheta added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 25, 2022
@sesheta
Copy link
Member

sesheta commented Mar 25, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from gregory-pereira after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Gregory-Pereira Gregory-Pereira force-pushed the modify-overlay-kustomizations-for-opfcli-compatability branch from 73ae8e8 to 8be27b6 Compare March 25, 2022 01:57
@Gregory-Pereira Gregory-Pereira force-pushed the modify-overlay-kustomizations-for-opfcli-compatability branch 6 times, most recently from b248174 to 8727357 Compare April 28, 2022 17:58
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 28, 2022
Kustomization overlays have been restructured to be compatable with the opfcli onboard command. This will produce, small and isolated diffs when onboarding with the opfcli rather than large ones that compete based on formatting rules.
@Gregory-Pereira Gregory-Pereira force-pushed the modify-overlay-kustomizations-for-opfcli-compatability branch from 8727357 to ce2b4f9 Compare April 28, 2022 18:01
@sesheta
Copy link
Member

sesheta commented Apr 28, 2022

@Gregory-Pereira: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit ce2b4f9 link true /test pre-commit
aicoe-ci/prow/kustomize-build ce2b4f9 link true /test kustomize-build

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sesheta
Copy link
Member

sesheta commented Jul 27, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 27, 2022
@SamoKopecky
Copy link
Member

/remove-lifecycle stale

@Gregory-Pereira Are you planning to work on this more?

@Gregory-Pereira
Copy link
Member Author

were moving away from using the opfcli for onboarding.
/close

@sesheta sesheta closed this Aug 18, 2022
@sesheta
Copy link
Member

sesheta commented Aug 18, 2022

@Gregory-Pereira: Closed this PR.

Details

In response to this:

were moving away from using the opfcli for onboarding.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants