Define new template specification #75
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, bundles could include both Slack and HipChat templates. With
the new templating engine, we now only need one template (the specific
chat provider implementations will be responsible for rendering the
template in a manner appropriate to the chat platform).
Now, templates look like this:
```
...
"templates": {
"template1": {"body": "template1 body"},
"template2": {"body": "template2 body"},
...
}
...
```
Note now that template names are also constrained to the regex
`[A-Za-z0-9_]+`.
This sets the current bundle definition version to 4, and officially
removes support for version 2 bundles. Version 3 is now officially
deprecated.
christophermaier
force-pushed
the
cm/new-template-config-version
branch
from
98a2f5a to
da2b478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, bundles could include both Slack and HipChat templates. With
the new templating engine, we now only need one template (the specific
chat provider implementations will be responsible for rendering the
template in a manner appropriate to the chat platform).
Now, templates look like this:
Note now that template names are also constrained to the regex
[A-Za-z0-9_]+.This sets the current bundle definition version to 4, and officially
removes support for version 2 bundles. Version 3 is now officially
deprecated.