secure pipeline command #1370
Merged
secure pipeline command #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christophermaier
approved these changes
Feb 22, 2017
Collaborator
christophermaier
left a comment
christophermaier
left a comment
There was a problem hiding this comment.
Looks good. Left a comment about a potential DRY opportunity. I think it would also be useful to add something to these command docs indicating that the scope of the results is going to be dependent on either who you are or what your permissions are.
lib/cog/commands/pipeline/list.ex
Outdated
| perm = Permissions.by_name("operable:manage_user_pipeline") | ||
| if User.has_permission(req_user, perm) do | ||
| {:ok, HistoryRepo.pipelines_for_user(app_user.id, Map.get(opts, "last", 20))} | ||
| else |
Collaborator
There was a problem hiding this comment.
Could we consolidate some of this? Seems like it's doing the same kind of checks as in other places in this PR (e.g. if has_perm? || entry.user.id == req_user.id do...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a hardcoded permission to the pipeline command limiting who can manage pipelines to the owning user and users with the
operable:manage_user_pipelinepermission.resolves #1327