-
Notifications
You must be signed in to change notification settings - Fork 3.1k
docker: add pulsar example #3789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # | ||
| # Copyright The OpenZipkin Authors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
|
|
||
| # This file uses the version 2 docker compose file format, described here: | ||
| # https://docs.docker.com/compose/compose-file/#version-2 | ||
| # | ||
| # It extends the default configuration from docker-compose.yml to add a test | ||
| # pulsar server, which is used as a span transport. | ||
|
|
||
| version: '2.4' | ||
|
|
||
| services: | ||
| pulsar: | ||
| image: ghcr.io/openzipkin/zipkin-pulsar:${TAG:-latest} | ||
| container_name: pulsar | ||
| ports: # expose the pulsar port so apps can publish spans. | ||
| - "6650:6650" | ||
| - "8080:8080" | ||
|
||
|
|
||
| zipkin: | ||
| extends: | ||
| file: docker-compose.yml | ||
| service: zipkin | ||
| # slim doesn't include Pulsar support, so switch to the larger image | ||
| image: ghcr.io/openzipkin/zipkin:${TAG:-latest} | ||
| environment: | ||
| - PULSAR_SERVICE_URL=pulsar://pulsar:6650 | ||
| depends_on: | ||
| pulsar: | ||
| condition: service_healthy | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # | ||
| # Copyright The OpenZipkin Authors | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
|
|
||
|
|
||
| # Use latest from https://hub.docker.com/r/apachepulsar/pulsar/tags | ||
| ARG pulsar_version=4.0.2 | ||
|
|
||
| # We copy files from the context into a scratch container first to avoid a problem where docker and | ||
| # docker compose don't share layer hashes https://github.com/docker/compose/issues/883 normally. | ||
| # COPY --from= works around the issue. | ||
| FROM scratch as scratch | ||
|
|
||
| WORKDIR /docker-bin | ||
| COPY build-bin/docker/docker-healthcheck /docker-bin/ | ||
|
|
||
| ARG pulsar_version | ||
|
|
||
| FROM apachepulsar/pulsar:${pulsar_version} as zipkin-pulsar | ||
| LABEL pulsar-version=$pulsar_version | ||
| LABEL org.opencontainers.image.description="Apache Pulsar on Alpine Linux" | ||
|
|
||
| # Add HEALTHCHECK and ENTRYPOINT scripts into the default search path | ||
| COPY --from=scratch /docker-bin/* /usr/local/bin/ | ||
| # We use start period of 30s to avoid marking the container unhealthy on slow or contended CI hosts | ||
| HEALTHCHECK --interval=1s --start-period=30s --timeout=5s CMD ["docker-healthcheck"] | ||
|
|
||
| # Usually, we read env set from pid 1 to get docker-healthcheck parameters. | ||
| # However, pulsar-server has to start as root even if permissions are dropped | ||
| # later. So, we expose it in the Dockerfile instead. | ||
| ENV HEALTHCHECK_PORT=8080 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. shouldn't we check the service port 6650 (esp if we are using tcp)
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I modified it to HTTP on port 8080, which is enough for the healthcheck.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok mainly I was concerned about race condition where 8080 is ready, but service port not. If this becomes a problem we can revisit |
||
| ENV HEALTHCHECK_KIND=tcp | ||
| EXPOSE 8080 6650 | ||
| CMD ["bin/pulsar", "standalone"] | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| ## zipkin-pulsar Docker image | ||
|
|
||
| The `zipkin-pulsar` testing image runs Pulsar for Pulsar collector integration. | ||
|
|
||
| To build `openzipkin/zipkin-pulsar:test`, from the top-level of the repository, run: | ||
| ```bash | ||
| $ DOCKER_FILE=docker/test-images/zipkin-pulsar/Dockerfile build-bin/docker/docker_build openzipkin/zipkin-pulsar:test | ||
| ``` |
Uh oh!
There was an error while loading. Please reload this page.