-
-
Notifications
You must be signed in to change notification settings - Fork 34
kiwix oauth2 with ory.sh #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
kiwix oauth2 with ory.sh #1518
Conversation
|
@elfkuzco is kinda blocked in testing this code by the fact that:
I've posted a message on Ory Slack to get assistance, but it looks like we do not have any support besides documentation in our ory.sh plan. |
|
We could probably use our own tunneling service in fact. I've configured "https://*loca.lt" (from https://localtunnel.me/) as redirect URL and CORS, let's me know if it does work (or not, but let's hope for the best) |
e773d11 to
0fda57b
Compare
|
The local tunnel closes unexpectedly after some minutes and says tunnel error. I think ngrok is more reliable than them. I have been using their free tunneling and it works quite fine You could try: https://*ngrok-free.app |
960c46a to
f85c39f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
==========================================
+ Coverage 83.38% 83.48% +0.10%
==========================================
Files 91 91
Lines 4394 4470 +76
Branches 468 477 +9
==========================================
+ Hits 3664 3732 +68
- Misses 608 613 +5
- Partials 122 125 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@elfkuzco can you try to:
|
0e78391 to
ea8f991
Compare
Rationale
This PR begins integration of Kiwix oauth2 authentication with ory.sh
Changes
/meendpoint instead of storing the roles in tokensidp_sub) to users. This will the same as theirsubfrom ory.shThis closes #1509