PR #36046: [ROCm] Fix failing unit tests on ROCm platform#36397
Closed
copybara-service[bot] wants to merge 1 commit into
Closed
PR #36046: [ROCm] Fix failing unit tests on ROCm platform#36397copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_856068530
branch
4 times, most recently
from
48633a3 to
96b0553
Compare
Imported from GitHub PR #36046 📝 Summary of Changes - layout_assignment tests are marked cuda-only. - sample_file_test needs higher autotuner level for MIOpen to return conv algorithm. Earlier this was coming from GetDebugOptionsForTest. - buffer_debug_log test is made gpu agnostic by using cannonical gpu name. - cublas_gemm_rewriter_test_amdgpu_any fix unit test to remove padding for ROCm as introduced in #33854 - gpu_kernel_tiling_test_amdgpu_any is updated to respect higher launch dimensions now supported by hipruntime - Mark dynamic_shared_memory_test as cuda-only - Add arch specific checks for barriers to sorting.hlo 🎯 Justification Fixes failing unit tests on ROCm platform 🚀 Kind of Contribution 🐛 Bug Fix, 🧪 Tests Copybara import of the project: -- 472cd54 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: [ROCm] Fix failing unit tests on ROCm platform - layout_assignment tests are marked cuda-only. - sample_file_test needs higher autotuner level for MIOpen to return conv algorithm. Earlier this was coming from GetDebugOptionsForTest. - buffer_debug_log test is made gpu agnostic by using cannonical gpu name. -- 3bb9422 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: Fix tests which started to fail due to #33854 -- 850d955 by Harsha HS <Harsha.HavanurShamsundara@amd.com>: HIP now respects highter launch dimension similar to CUDA -- b504a7e by Harsha HS <Harsha.HavanurShamsundara@amd.com>: Make dynamic_shared_memory_test cuda only -- 1e4e57a by Harsha HS <Harsha.HavanurShamsundara@amd.com>: Add arch specific checks to sorting.hlo -- ce1241c by Harsha HS <Harsha.HavanurShamsundara@amd.com>: Address review comments Merging this change closes #36046 FUTURE_COPYBARA_INTEGRATE_REVIEW=#36046 from ROCm:ci_fix_upstream_ut_20260107 ce1241c PiperOrigin-RevId: 856068530
copybara-service
Bot
force-pushed
the
test_856068530
branch
from
96b0553 to
2b9de3a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #36046: [ROCm] Fix failing unit tests on ROCm platform
Imported from GitHub PR #36046
📝 Summary of Changes
🎯 Justification
Fixes failing unit tests on ROCm platform
🚀 Kind of Contribution
🐛 Bug Fix, 🧪 Tests
Copybara import of the project:
--
472cd54 by Harsha HS Harsha.HavanurShamsundara@amd.com:
[ROCm] Fix failing unit tests on ROCm platform
conv algorithm. Earlier this was coming from GetDebugOptionsForTest.
--
3bb9422 by Harsha HS Harsha.HavanurShamsundara@amd.com:
Fix tests which started to fail due to #33854
--
850d955 by Harsha HS Harsha.HavanurShamsundara@amd.com:
HIP now respects highter launch dimension similar to CUDA
--
b504a7e by Harsha HS Harsha.HavanurShamsundara@amd.com:
Make dynamic_shared_memory_test cuda only
--
1e4e57a by Harsha HS Harsha.HavanurShamsundara@amd.com:
Add arch specific checks to sorting.hlo
--
ce1241c by Harsha HS Harsha.HavanurShamsundara@amd.com:
Address review comments
Merging this change closes #36046
FUTURE_COPYBARA_INTEGRATE_REVIEW=#36046 from ROCm:ci_fix_upstream_ut_20260107 ce1241c