Skip to content

[ROCm] Skip conditional tests on ROCm as they are not supported by HIP Graphs #36283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hsharsha wants to merge 1 commit into from
Closed

[ROCm] Skip conditional tests on ROCm as they are not supported by HIP Graphs #36283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions xla/service/gpu/tests/command_buffer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,9 @@ class CommandBufferTest
public ::testing::WithParamInterface<
DebugOptions::CommandBufferSchedulingMode> {
protected:
bool IsRocm() {
return test_runner().HasProperty(HloRunnerPropertyTag::kUsingGpuRocm);
}
DebugOptions GetDebugOptionsForTest() const override {
DebugOptions debug_options = HloPjRtTestBase::GetDebugOptionsForTest();
debug_options.set_xla_gpu_command_buffer_scheduling_mode(GetParam());
Expand Down Expand Up @@ -297,6 +300,9 @@ TEST_P(CommandBufferTest, TracedCustomCalls) {
}

TEST_P(CommandBufferTest, TrueFalseConditional) {
if(IsRocm()) {
GTEST_SKIP() << "Graph conditionals are not yet supported on HIP graphs";
}
constexpr absl::string_view hlo_text = R"(
HloModule m, is_scheduled=true

Expand Down Expand Up @@ -356,6 +362,9 @@ TEST_P(CommandBufferTest, TrueFalseConditional) {
}

TEST_P(CommandBufferTest, IndexConditional) {
if(IsRocm()) {
GTEST_SKIP() << "Graph conditionals are not yet supported on HIP graphs";
}
constexpr absl::string_view hlo_text = R"(
HloModule m, is_scheduled=true

Expand Down Expand Up @@ -423,6 +432,9 @@ TEST_P(CommandBufferTest, IndexConditional) {
}

TEST_P(CommandBufferTest, WhileLoop) {
if(IsRocm()) {
GTEST_SKIP() << "Graph conditionals are not yet supported on HIP graphs";
}
constexpr absl::string_view hlo_text = R"(
HloModule m, is_scheduled=true

Expand Down
Loading