PR #27498: [ROCm] Add new hip_runtime bazel target #27638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_769500297
branch
from
f0202e4 to
184d4d4
Compare
Imported from GitHub PR #27498 In the jaxlib extension for ROCm, we need to link to the HIP runtime (libamdhip64.so) but without the extra links that are on rocm_hip, such as comgr, rocm-smi, and HSA runtime (which are linked by libamdhip itself) Comgr shouldn't be directly linked by any HIP users either, but that hasn't been an issue for others apparently, so add this target that we can use from jaxlib and not intefere with rocm_hip. Copybara import of the project: -- 82a3ab3 by Mathew Odden <[email protected]>: [ROCm] Add new hip_runtime bazel target In the jaxlib extension for ROCm, we need to link to the HIP runtime (libamdhip64.so) but without the extra links that are on rocm_hip, such as comgr, rocm-smi, and HSA runtime (which are linked by libamdhip itself) Comgr shouldn't be directly linked by any HIP users either, but that hasn't been an issue for others apparently, so add this target that we can use from jaxlib and not intefere with rocm_hip. Merging this change closes #27498 COPYBARA_INTEGRATE_REVIEW=#27498 from mrodden:rocm-add-hip-runtime-target 82a3ab3 PiperOrigin-RevId: 770082371
copybara-service
bot
force-pushed
the
test_769500297
branch
from
184d4d4 to
1d6956a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #27498: [ROCm] Add new hip_runtime bazel target
Imported from GitHub PR #27498
In the jaxlib extension for ROCm, we need to link to the HIP runtime (libamdhip64.so) but without the extra links that are on rocm_hip, such as comgr, rocm-smi, and HSA runtime (which are linked by libamdhip itself)
Comgr shouldn't be directly linked by any HIP users either, but that hasn't been an issue for others apparently, so add this target that we can use from jaxlib and not intefere with rocm_hip.
Copybara import of the project:
--
82a3ab3 by Mathew Odden [email protected]:
[ROCm] Add new hip_runtime bazel target
In the jaxlib extension for ROCm, we need to link to
the HIP runtime (libamdhip64.so) but without the extra
links that are on rocm_hip, such as comgr, rocm-smi, and
HSA runtime (which are linked by libamdhip itself)
Comgr shouldn't be directly linked by any HIP users either,
but that hasn't been an issue for others apparently, so
add this target that we can use from jaxlib and not intefere
with rocm_hip.
Merging this change closes #27498
FUTURE_COPYBARA_INTEGRATE_REVIEW=#27498 from mrodden:rocm-add-hip-runtime-target 82a3ab3