Skip to content

janitor: don't delete old images #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2023
Merged

janitor: don't delete old images #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions asu/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,8 +319,6 @@ def build(req: dict, job=None):

log.debug("JSON content %s", json_content)

job.connection.sadd(f"builds:{version_code}:{req['target']}", req["request_hash"])

# Increment stats
job.connection.hincrby(
"stats:builds",
Expand Down
16 changes: 0 additions & 16 deletions asu/janitor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,22 +106,6 @@ def update_target_profiles(config, branch: dict, version: str, target: str) -> s

r.hset(f"architecture:{branch['name']}", target, metadata["arch_packages"])

queue = Queue(connection=r)
registry = FinishedJobRegistry(queue=queue)
version_code = r.get(f"revision:{version}:{target}")
if version_code:
version_code = version_code.decode()
for request_hash in r.smembers(f"builds:{version_code}:{target}"):
logging.warning(f"{version_code}/{target}: Delete outdated job build")
try:
request_hash = request_hash.decode()
registry.remove(request_hash, delete_job=True)
rmtree(config["STORE_PATH"] / request_hash)

except NoSuchJobError:
logging.warning("Job was already deleted")
r.delete(f"builds:{version_code}:{target}")

r.set(
f"revision:{version}:{target}",
metadata["version_code"],
Expand Down