fixed release_date in janitor.py #428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
aparcar
requested changes
Dec 29, 2022
Member
|
Thanks for your contribution and the quick fix! |
Codecov ReportBase: 85.39% // Head: 85.39% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 85.39% 85.39%
=======================================
Files 13 13
Lines 1150 1150
=======================================
Hits 982 982
Misses 168 168
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Member
|
Could you please add the PR text to the commit message? |
aparcar
approved these changes
Dec 29, 2022
The janitor would fail if a branch node contained a date value. As a result, the branches.json, latest.json and overview.json files are never created and therefore acu and/or luci-app-attendedsysupgrade would not be able to update from the asu instance. Converting json node values to string by default fixes the issue. Signed-off-by: Marc Ahlgrim <[email protected]>
onemarcfifty
force-pushed
the
fix-json-date
branch
from
72d6164 to
8592980
Compare
Contributor
Author
|
added PR text to commit |
Member
|
Awesome thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The janitor would fail if a branch node contained a date value. As a result, the branches.json, latest.json and overview.json files are never created and therefore acu and/or luci-app-attendedsysupgrade would not be able to update from the asu instance.
Converting json node values to string by default fixes the issue.
This fixes #427
Signed-off-by: Marc Ahlgrim [email protected]