Skip to content

branches: add revision and mandatory to changes #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 10, 2022
Merged

branches: add revision and mandatory to changes #404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions asu/branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@ branches:
- 22.03.0-rc6
- 22.03-SNAPSHOT
package_changes:
kmod-nft-nat6:
firewall: firewall4
- source: kmod-nft-nat6
revision: 19160
mandatory: true
- source: firewall
target: firewall4
revision: 18611

"21.02":
enabled: true
Expand Down Expand Up @@ -67,5 +71,9 @@ branches:
versions:
- SNAPSHOT
package_changes:
kmod-nft-nat6:
firewall: firewall4
- source: kmod-nft-nat6
revision: 20282
mandatory: true
- source: firewall
target: firewall4
revision: 18611
Copy link
Member

@dangowrt dangowrt Oct 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As both changes (firewall -> firewall4, kmod-nft-nat6 -> null) are present already in the 22.03 release branch, why do you list them again in SNAPSHOT? That makes it much harder for the client to decide which changes to include...