api: drop server side handling of package_changes #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes more issues than good. The server must only provide such information and the client should request the user what do to or may "auto default" to what `package_changes` suggest. Changing this on the server side confuses clients that compare the requested list of packages with the resulting list of packages. Signed-off-by: Paul Spooren <[email protected]>
|
CC: @dangowrt I'll implement this for LuCI, please do so for |
Codecov ReportBase: 85.08% // Head: 84.71% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 85.08% 84.71% -0.38%
==========================================
Files 13 13
Lines 1153 1138 -15
==========================================
- Hits 981 964 -17
- Misses 172 174 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes more issues than good. The server must only provide such information and the client should request the user what do to or may "auto default" to what
package_changessuggest.Changing this on the server side confuses clients that compare the requested list of packages with the resulting list of packages.
Signed-off-by: Paul Spooren [email protected]