This repository was archived by the owner on Jun 27, 2020. It is now read-only.
[ci] Add JSLint #82
Merged
[ci] Add JSLint #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
suggested changes
Jan 15, 2018
Member
nemesifier
left a comment
nemesifier
left a comment
There was a problem hiding this comment.
The changes to the JS look good!
Proceed as follows please:
- read my inline comment, but don't do anything yet
- rebase your work from the current master, resolve conflicts
Thanks 👍
.travis.yml
Outdated
| - python setup.py -q develop | ||
|
|
||
| script: | ||
| - jslint django_netjsongraph/static/netjsongraph/js/*.js |
Member
There was a problem hiding this comment.
let's put this check in the before_install section so we avoid can let the build fail before the django dependencies are installed if any style issue is present, this way we can know much faster if there's a problem
|
Changes Unknown when pulling 90d2b66 on BrainBuzzer:master into ** on netjson:master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.