This repository was archived by the owner on Jun 27, 2020. It is now read-only.
[admin] action update_selected_topologies now ignores topologies with… #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohithasrk
reviewed
Jan 7, 2018
Contributor
rohithasrk
left a comment
rohithasrk
left a comment
There was a problem hiding this comment.
@R9295 Can you add a test for the same? Ensure that the coverage doesn't go down.
… RECEIVE strategy openwisp#71 closes openwisp#71
rohithasrk
approved these changes
Jan 9, 2018
Contributor
There was a problem hiding this comment.
@R9295. Looks good. 👍
@nemesisdesign What do you think?
nemesifier
approved these changes
Feb 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… RECEIVE strategy #71
closes #71